Add the .targets file to buildTransitive #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
type/enhancement
area/SkiaSharp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add the .targets file to the
buildTransitivefolder in the NuGet package. This only applies to net45 and Full Framework apps. This makes sure that the .targets file is always referenced and the native files are always copied as part of the build.The main issue this solves is for transitive dependencies with App -> Core -> ThirdParty -> SkiaSharp. In this scenario, the native libraries will only be copied as part of build for ThirdParty - which is not even part of the project. As a result, the app will never get the binaries. After this PR, each level will get the binaries, including the App and Core.
Bugs Fixed
API Changes
None.
Behavioral Changes
The libSkiaSharp.* binaries will always be copied to the output folder for all projects in the build.
PR Checklist