This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
[2019-02] iterate_dir: Include symlinks to dirs also #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given: `for root, subdirs, filelist in os.walk(dir):` .. symlinks to directories are only returned in `subdirs`. So, they need to handled explicitly. This meant that when bockbuild tried to zip up the contents of mono and msbuild to move to the staging directory, then such symlinks were not picked up thus breaking the build. (cherry picked from commit 5d818c1)
9 tasks
radical
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given:
for root, subdirs, filelist in os.walk(dir):.. symlinks to directories are only returned in
subdirs. So, they needto handled explicitly.
This meant that when bockbuild tried to zip up the contents of mono and
msbuild to move to the staging directory, then such symlinks were not
picked up thus breaking the build.
(cherry picked from commit 5d818c1)