PR Feedback

- Fix up formatting - Move from IList to IReadOnlyList where appropriate
mono · Jan 22, 2020 · e6e1057 · e6e1057
1 parent b0d4b24
commit e6e1057
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/...velop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs b/...velop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
@@ -59,7 +59,7 @@ public AuthenticationParameter (string name)
 			Name = name;
 		}
 
-		public static IList<AuthenticationParameter> CreateSupportedParameterList (IReadOnlyDictionary<string, string> parameterChoices)
+		public static IReadOnlyList<AuthenticationParameter> CreateSupportedParameterList (IReadOnlyDictionary<string, string> parameterChoices)
 		{
 			return parameterChoices.Where (choice => supportedParameters.Contains (choice.Key))
 				.Select (parameter => new AuthenticationParameter (parameter.Key))
@@ -69,7 +69,7 @@ public static IList<AuthenticationParameter> CreateSupportedParameterList (IRead
 
 	class DotNetCoreProjectTemplateParameters
 	{
-		public static IList<AuthenticationParameter> GetAuthenticationParameters (string templateId)
+		public static IReadOnlyList<AuthenticationParameter> GetAuthenticationParameters (string templateId)
 		{
 			if (IdeServices.TemplatingService.GetSolutionTemplate (templateId) is MicrosoftTemplateEngineSolutionTemplate template) {
 				if (template.IsSupportedParameter (AuthenticationParameter.ParameterName)) {

diff --git a/...noDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs b/...noDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs
@@ -52,7 +52,7 @@ public override WizardPage GetPage (int pageNumber)
 
 		internal IList<TargetFramework> TargetFrameworks => targetFrameworks;
 
-		internal IList<AuthenticationParameter> SupportedAuthentications { get; private set; }
+		internal IReadOnlyList<AuthenticationParameter> SupportedAuthentications { get; private set; }
 
 		/// <summary>
 		/// When only .NET Core 2.0 is installed there is only one option in the drop down

diff --git a/...velop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs b/...velop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs
@@ -43,7 +43,7 @@ class DotNetCoreProjectTemplateWizardPage : WizardPage
 		public DotNetCoreProjectTemplateWizardPage (
 			DotNetCoreProjectTemplateWizard wizard,
 			List<TargetFramework> targetFrameworks,
-			IList<AuthenticationParameter> supportedAuthentications)
+			IReadOnlyList<AuthenticationParameter> supportedAuthentications)
 		{
 			this.wizard = wizard;
 			this.targetFrameworks = targetFrameworks;
@@ -118,7 +118,7 @@ void UpdateTargetFrameworkParameters ()
 				wizard.Parameters [parameter] = "true";
 		}
 
-        public IList<AuthenticationParameter> SupportedAuthentications { get; }
+		public IReadOnlyList<AuthenticationParameter> SupportedAuthentications { get; }
 
 		int selectedAuthenticationIndex;