This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Sync vs-editor-api and adopt code to changes #9457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
approved these changes
Dec 16, 2019
sandyarmstrong
added
the
Area: VS Text Editor
sandyarmstrong
force-pushed
the
removeITextView3
branch
from
fd06346 to
c4bdc23
Compare
sandyarmstrong
approved these changes
Dec 18, 2019
|
Shouldn't the !WINDOWS defines be changed to MAC? otherwise compilation will fail on Linux. |
|
@knocte this is new editor infrastructure, which is not yet supported at all on Linux. If it was, it would use the same APIs as Mac, which sometimes differ from what is available on Windows. So these defines are correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.