This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
[Debugger] Update VSCodeDebuggerSession Step methods to send requests… #9552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Therzok
approved these changes
Jan 15, 2020
mrward
approved these changes
Jan 15, 2020
|
The following gif shows how stepping is now instant:
|
jstedfast
force-pushed
the
jstedfast-debugger-session-step-avoid-threadpool-queue
branch
2 times, most recently
from
813653e to
5e53b17
Compare
jstedfast
force-pushed
the
jstedfast-debugger-session-step-avoid-threadpool-queue
branch
from
5e53b17 to
872072f
Compare
|
This PR depends on mono/debugger-libs#282 |
ketttY
approved these changes
Jan 22, 2020
Therzok
reviewed
Jan 22, 2020
| try { | ||
| protocolClient.SendRequestSync (new StepOutRequest (currentThreadId)); | ||
| } catch (Exception ex) { | ||
| protocolClient.SendRequest (new StepOutRequest (currentThreadId), null, (args, ex) => { |
There was a problem hiding this comment.
Will this mean the method exits before the step is done?
There was a problem hiding this comment.
It just means we won't block until the response is received
sgmunn
deleted the
jstedfast-debugger-session-step-avoid-threadpool-queue
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… async
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/804257/