Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

[Ide] Dynamically add ~contrast~dark~sel resource mappings #9590

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

sevoku
Copy link
Member

@sevoku sevoku commented Jan 23, 2020

to avoid adding duplicate EmbeddedResource entries to project files.

Background:

To support loading the correct icons in selected state with dark theme and high contrast mode, we'd need to add duplicate resources entries to all csproj file like this:

     <EmbeddedResource Include="icons\project-32~dark~sel.png" />
+    <EmbeddedResource Include="icons\project-32~dark~sel.png" >
+      <LogicalName>project-32~contrast~dark~sel.png</LogicalName>
+    </EmbeddedResource>
     <EmbeddedResource Include="icons\project-32~dark~sel%402x.png" />
+    <EmbeddedResource Include="icons\project-32~dark~sel%402x.png" >
+      <LogicalName>[email protected]</LogicalName>
+    </EmbeddedResource>

this could be automated, but would be hard to maintain afterwards (it's already quite hard with all icons we have). With this change we don't need any duplicates.

@sevoku sevoku requested a review from Therzok January 23, 2020 13:44
@sevoku sevoku requested a review from slluis as a code owner January 23, 2020 13:44
to avoid adding duplicate EmbeddedResource entries to project files.
@sevoku sevoku force-pushed the fix-hc-dark-sel-icon-loader branch from 1705616 to 11fd096 Compare January 23, 2020 14:51
@sevoku sevoku force-pushed the fix-hc-dark-sel-icon-loader branch from 8e71b7c to f5db883 Compare January 23, 2020 15:26
@mono mono deleted a comment from monojenkins Jan 23, 2020
@sevoku sevoku merged commit 7642846 into master Jan 23, 2020
@Therzok Therzok deleted the fix-hc-dark-sel-icon-loader branch January 23, 2020 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants