Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with semantic import versioning #211

Closed
wants to merge 1 commit into from
Closed

Comply with semantic import versioning #211

wants to merge 1 commit into from

Conversation

Loyalsoldier
Copy link

No description provided.

@Loyalsoldier
Copy link
Author

For Go v1.15.6 in Homebrew Homebrew/homebrew-core#66355

@carlocab
Copy link

Thanks, @Loyalsoldier.

If this PR is merged, it would also be helpful for Homebrew if you cut a new release that includes this PR. At the moment CI failures associated with formulae that still depend on godep is holding back the go version bump.

@shigemk2
Copy link

How about wercker.yml?
the_platinum_searcher uses wercker as CI tool.
We have to delete godep from wercker.yml https://github.com/monochromegane/the_platinum_searcher/blob/master/wercker.yml#L5-L18.

@carlocab
Copy link

If you make that change, please squash your commits so I only need one commit hash for the Homebrew patch.

@shigemk2
Copy link

Well, I do not have to fix wercker.yml right away because wercker uploads artifacts.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Dec 12, 2020
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants