Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.26 Dependency Upgrade #1699

Merged
merged 8 commits into from
Aug 1, 2022
Merged

0.9.26 Dependency Upgrade #1699

merged 8 commits into from
Aug 1, 2022

Conversation

nanocryk
Copy link
Contributor

@nanocryk nanocryk commented Jul 21, 2022

Upgrade to substrate used in Polkadot 0.9.26 (#1691), and include all changes in our main dependencies.

Custom branches (with diffs from parity's branches) :

Runtime breaking changes

Client breaking changes

Refactoring

  • Since it went throught many changes I remade frontier pool formatting from the latest state. Since being generic over multiple formats seems to no longer be wanted, I called the Geth formatter directly in frontier and removed the additional parameter. We should review this new code to ensure it matches the expected errors.

Left to do

  • Storage remove_prefix is deprecated. I changed it to clear_prefix with u32::MAX limit to keep the same behavior, but we should probably set a better limit.

@nanocryk nanocryk added A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C7-high Elevates a release containing this PR to "high priority". D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 21, 2022
@nazar-pc
Copy link

⚠️ Substrate now use a version of prost-build that requires protoc (Protobuf) to be installed. It must be thus installed by developpers and in the CI.

This is not true, current versions of prost-build will build protoc automatically, you don't need to have it installed. But you do have to have prerequisites like CMake for it to be built successfully.

@nanocryk
Copy link
Contributor Author

@nazar-pc I had the same issue than the CI, which seems to be that cmake is installed but called with unknown argument --parallel. Do you have any idea how to fix this?

@nazar-pc
Copy link

Not really, we're building nodes in CI on Windows Server 2022, macOS 12 and Ubuntu 20.04, in all cases everything compiles just fine with default GitHub actions workers. Here is the latest run if you want to compare workflow file: https://github.com/subspace/subspace/actions/runs/2729396930

prost-build version is the same too.

@crystalin
Copy link
Collaborator

@nanocryk is it missing anything to merge ?

@nanocryk nanocryk merged commit fc92891 into master Aug 1, 2022
@nanocryk nanocryk deleted the jeremy-polkadot-v0.9.26 branch August 1, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes C7-high Elevates a release containing this PR to "high priority". D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants