-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Upgrade to v1.3.0 #2589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
reviewed
Dec 18, 2023
Agusrodri
reviewed
Dec 18, 2023
librelois
approved these changes
Dec 19, 2023
Agusrodri
approved these changes
Dec 19, 2023
noandrea
added
the
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
label
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Breaking Changes
context
argument type infn deposit_asset
inxcm_executor::traits::TransactAsset
trait has changed fromXcmContext
toOption<&XcmContext>
Bounded
now also takes another generic parameter that represents the type of the hasher used.Hasher
set to<Runtime as frame_system::Config>::Hashing
IdentityInformation
is added to theConfig
trait of pallet identityIdentityInformation
toFieldInfo<MaxAdditionalFields>
InvalidEvmTransactionError
toTransactionValidationError
BackendReader
renamed toBackend
and moved to a new cratefc-api
Consideration
instead of handling deposits directly.BaseDeposit
andByteDeposit
from pallet preimageclosest_merkle_value
andchild_closest_merkle_value
added to theStorageProvider
traitStagingXcmVersionedXcm
has been renamed toXcmVersionedXcm
pallet_balances
'sset_balance_deprecated
andtransfer
dispatchablesforce_set_balance
andtransfer_allow_death
are used respectively.spend
dispatchable renamed tospend_local
spend
,payout
,check_payment
,void_spend
)What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?