Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Upgrade to v1.3.0 #2589

Merged
merged 57 commits into from
Dec 19, 2023
Merged

Conversation

ahmadkaouk
Copy link
Contributor

@ahmadkaouk ahmadkaouk commented Dec 11, 2023

What does it do?

Breaking Changes

  • Remove Kusama native runtime support
  • The context argument type in fn deposit_asset in xcm_executor::traits::TransactAsset trait has changed from XcmContext to Option<&XcmContext>
  • Bounded now also takes another generic parameter that represents the type of the hasher used.
    • Hasher set to <Runtime as frame_system::Config>::Hashing
  • New associated type IdentityInformation is added to the Config trait of pallet identity
    • Set IdentityInformation to FieldInfo<MaxAdditionalFields>
  • Rename InvalidEvmTransactionError to TransactionValidationError
  • BackendReader renamed to Backend and moved to a new crate fc-api
  • Preimage pallet use Consideration instead of handling deposits directly.
    • Remove BaseDeposit and ByteDeposit from pallet preimage
  • New closest_merkle_value and child_closest_merkle_value added to the StorageProvider trait
  • StagingXcmVersionedXcm has been renamed to XcmVersionedXcm
  • Remove deprecated  pallet_balances's  set_balance_deprecated and transfer dispatchables
    • Instead force_set_balance and transfer_allow_death are used respectively.
  • Support for treasury to spend various asset kinds
    • existing spend dispatchable renamed to spend_local
    • New dispatchables added (spend, payout, check_payment, void_spend)

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Coverage Report

@@                         Coverage Diff                          @@
##           master   ahmad-upgrade-to-polkadot-v1.3.0      +/-   ##
====================================================================
- Coverage   81.91%                             81.05%   -0.86%     
  Files         286                                286              
- Lines       95271                              94172    -1099     
====================================================================
- Hits        78035                              76322    -1713     
+ Misses      17236                              17850     +614     
Files Changed Coverage
/node/service/src/lib.rs 64.17% (+0.07%) 🔼
/pallets/asset-manager/src/mock.rs 93.81% (+0.03%) 🔼
/pallets/erc20-xcm-bridge/src/mock.rs 4.51% (-0.07%) 🔽
/pallets/ethereum-xcm/src/mock.rs 39.17% (-0.15%) 🔽
/pallets/moonbeam-orbiters/src/mock.rs 97.21% (+0.02%) 🔼
/pallets/proxy-genesis-companion/src/mock.rs 27.68% (-0.16%) 🔽
/pallets/xcm-transactor/src/mock.rs 92.08% (-0.90%) 🔽
/precompiles/author-mapping/src/mock.rs 18.28% (-0.30%) 🔽
/precompiles/batch/src/mock.rs 98.88% (+0.01%) 🔼
/precompiles/call-permit/src/mock.rs 23.27% (-0.45%) 🔽
/precompiles/collective/src/mock.rs 94.26% (+0.45%) 🔼
/precompiles/conviction-voting/src/mock.rs 93.33% (+0.05%) 🔼
/precompiles/crowdloan-rewards/src/mock.rs 98.06% (+0.02%) 🔼
/precompiles/gmp/src/mock.rs 8.35% (-0.13%) 🔽
/precompiles/identity/src/lib.rs 90.02% (-0.10%) 🔽
/precompiles/identity/src/mock.rs 97.09% (+0.05%) 🔼
/precompiles/pallet-democracy/src/lib.rs 90.87% (+0.10%) 🔼
/precompiles/pallet-democracy/src/mock.rs 97.96% (+0.03%) 🔼
/precompiles/pallet-democracy/src/tests.rs 89.33% (-0.20%) 🔽
/precompiles/parachain-staking/src/mock.rs 97.73% (+0.03%) 🔼
/precompiles/precompile-registry/src/mock.rs 24.52% (-0.32%) 🔽
/precompiles/preimage/src/mock.rs 97.63% (+0.01%) 🔼
/precompiles/proxy/src/mock.rs 94.14% (+0.05%) 🔼
/precompiles/randomness/src/mock.rs 95.48% (+0.07%) 🔼
/precompiles/referenda/src/mock.rs 97.52% (+0.01%) 🔼
/precompiles/relay-encoder/src/mock.rs 8.96% (-0.16%) 🔽
/precompiles/utils/tests-external/lib.rs 49.15% (-0.24%) 🔽
/precompiles/xcm-transactor/src/mock.rs 93.01% (-0.88%) 🔽
/precompiles/xcm-utils/src/mock.rs 95.67% (-0.87%) 🔽
/precompiles/xtokens/src/mock.rs 23.72% (+0.64%) 🔼
/runtime/common/src/apis.rs 85.28% (+0.03%) 🔼
/runtime/moonbase/src/lib.rs 49.28% (-0.33%) 🔽
/runtime/moonbase/tests/xcm_mock/parachain.rs 69.21% (-0.22%) 🔽
/runtime/moonbase/tests/xcm_mock/relay_chain.rs 56.00% (-4.22%) 🔽
/runtime/moonbeam/src/lib.rs 46.12% (-23.63%) 🔽
/runtime/moonbeam/tests/xcm_mock/parachain.rs 68.79% (-0.22%) 🔽
/runtime/moonbeam/tests/xcm_mock/relay_chain.rs 55.45% (-4.77%) 🔽
/runtime/moonriver/src/lib.rs 46.11% (-23.56%) 🔽
/runtime/moonriver/tests/xcm_mock/parachain.rs 69.97% (-0.22%) 🔽
/runtime/moonriver/tests/xcm_mock/relay_chain.rs 55.45% (-4.77%) 🔽
/runtime/relay-encoder/src/kusama.rs 0.00% (-97.46%) 🔽
/runtime/relay-encoder/src/polkadot.rs 0.00% (-97.46%) 🔽

Coverage generated Tue Dec 19 12:29:19 UTC 2023

@ahmadkaouk ahmadkaouk marked this pull request as ready for review December 18, 2023 16:03
@ahmadkaouk ahmadkaouk merged commit 1e4d3dd into master Dec 19, 2023
27 checks passed
@ahmadkaouk ahmadkaouk deleted the ahmad-upgrade-to-polkadot-v1.3.0 branch December 19, 2023 13:00
@noandrea noandrea added the B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants