evm-tracing should replay on_idle #2707
Merged
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B5-clientnoteworthy
Coverage Report@@ Coverage Diff @@
## master elois-tracing-on-idle +/- ##
========================================================
Coverage 73.44% 73.44% 0.00%
Files 229 229
Lines 70351 70351
========================================================
Hits 51669 51669
Misses 18682 18682
|
RomarQ
approved these changes
Mar 20, 2024
RomarQ
pushed a commit
that referenced
this pull request
Mar 21, 2024
* evm-tracing should replay on_idle * fix compilation * fix rust tests * not call on_finalize * create helper function replay_on_idle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
If incoming XCM messages consume more than 25% of the block, the extra xcm messages are deferred to on_idle to make room for user transactions.
If some of these sdefered xcm messages contains ethereum-xcm transactions, they are not traceable because vm-tracing does not replay on_idle.
Fix #2626
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?