Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace init.sh script with proper rust-toolchain file. #298

Merged
merged 14 commits into from
Mar 30, 2021
Merged

Replace init.sh script with proper rust-toolchain file. #298

merged 14 commits into from
Mar 30, 2021

Conversation

JoshOrndorff
Copy link
Contributor

@JoshOrndorff JoshOrndorff commented Mar 23, 2021 •
edited
Loading

What does it do?

This PR turns our rust-toolchain file into a proper toml format that specifies not only the nightly version, but also toolchains (wasm32-unknown-unknown) and components (clipy, rustfmt).

This will help the wasm builder avoid problems with the wrong toolchain.

What value does it bring to the blockchain users?

Fewer places to get stuck or confused when building the node.

Checklist

  • ❌ Does it require a purge of the network?
  • ❌ You bumped the runtime version if there are breaking changes in the runtime ?
  • ❌ Does it require changes in documentation/tutorials ?

@JoshOrndorff JoshOrndorff force-pushed the joshy-rust-toolchain-toml branch from 185e40c to 2b7dec7 Compare March 23, 2021 18:20
@JoshOrndorff JoshOrndorff marked this pull request as draft March 23, 2021 19:25
@JoshOrndorff
Copy link
Contributor Author

Well, this is basically blocked by actions-rs/toolchain#126 Once we have a way to install rustup in CI, this should remove the last pains associated with toolchains.

@JoshOrndorff JoshOrndorff force-pushed the joshy-rust-toolchain-toml branch from efbb2b9 to f177a2e Compare March 30, 2021 16:06
@JoshOrndorff JoshOrndorff marked this pull request as ready for review March 30, 2021 17:46
@JoshOrndorff JoshOrndorff requested a review from notlesh March 30, 2021 17:46
@JoshOrndorff
Copy link
Contributor Author

JoshOrndorff commented Mar 30, 2021 •
edited
Loading

Thanks for the help installing rustup on the runner @purestakeoskar

@JoshOrndorff JoshOrndorff added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". labels Mar 30, 2021
@JoshOrndorff JoshOrndorff requested a review from 4meta5 March 30, 2021 18:36
notlesh
notlesh approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@notlesh notlesh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JoshOrndorff JoshOrndorff merged commit 83d4b5d into master Mar 30, 2021
@JoshOrndorff JoshOrndorff deleted the joshy-rust-toolchain-toml branch March 30, 2021 19:30
@JoshOrndorff JoshOrndorff mentioned this pull request Apr 7, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlesh notlesh notlesh approved these changes

@4meta5 4meta5 Awaiting requested review from 4meta5

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshOrndorff @notlesh