Deprecate generate-account-key in favour of generate-moonbeam-key #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B5-clientnoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/remove-moonkey +/- ##
====================================================
Coverage 74.58% 74.58% 0.00%
- Files 375 374 -1
+ Lines 95682 95686 +4
====================================================
Hits 71359 71359
+ Misses 24323 24327 +4
|
crystalin
reviewed
Dec 10, 2024
| @@ -372,7 +373,10 @@ pub enum KeyCmd { | |||
| #[clap(flatten)] | |||
| BaseCli(sc_cli::KeySubcommand), | |||
| /// Generate an Ethereum account. | |||
| #[clap(about = "This command is deprecated, please use `generate-moonbeam-key` instead.")] | |||
There was a problem hiding this comment.
Can we make it so it points to this PR with explanation about why it is deprecated and the difference between the 2.
| @@ -53,7 +53,11 @@ impl GenerateAccountKey { | |||
|
|
|||
| // Retrieves the seed from the mnemonic | |||
| let seed = Seed::new(&mnemonic, ""); | |||
| let derivation_path = format!("m/44'/60'/0'/0/{}", self.account_index.unwrap_or(0)); | |||
| let derivation_path = if deprecated { | |||
There was a problem hiding this comment.
We should allow to pass a --network moonbeam|moonriver|moonbase|ethereum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
generate-account-keyin favour ofgenerate-moonbeam-key. Which uses the correctcoin_type.moonkeyutilitymoonbeam key generate-account-keywill now output a warning: