Send priority fees to collators #3120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarekkMA
added
B7-runtimenoteworthy
WASM runtime size check:Compared to target branchMoonbase runtime: 2268 KB (no changes) ✅ Moonbeam runtime: 2240 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2268 KB (+240 KB compared to latest release) Moonbeam runtime: 2240 KB (+228 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master tarekkma/priority-fees +/- ##
==========================================================
+ Coverage 74.40% 74.53% +0.13%
- Files 376 375 -1
+ Lines 95432 95469 +37
==========================================================
+ Hits 70998 71154 +156
- Misses 24434 24315 -119
|
RomarQ
reviewed
Jan 10, 2025
Comment on lines
+402
to
+425
| pub struct BlockAuthorAccountId<R>(PhantomData<R>); | ||
| impl<R> TypedGet for BlockAuthorAccountId<R> | ||
| where | ||
| R: frame_system::Config + pallet_author_inherent::Config, | ||
| pallet_author_inherent::Pallet<R>: Get<R::AccountId>, | ||
| { | ||
| type Type = R::AccountId; | ||
| fn get() -> Self::Type { | ||
| <pallet_author_inherent::Pallet<R> as Get<R::AccountId>>::get() | ||
| } | ||
| } | ||
|
|
||
| /// Deal with ethereum based priority fees/tips. See DealWithEthereumBaseFees for base fees. | ||
| pub struct DealWithEthereumPriorityFees<R>(sp_std::marker::PhantomData<R>); | ||
| impl<R> OnUnbalanced<Credit<R::AccountId, pallet_balances::Pallet<R>>> | ||
| for DealWithEthereumPriorityFees<R> | ||
| where | ||
| R: pallet_balances::Config + pallet_author_inherent::Config, | ||
| pallet_author_inherent::Pallet<R>: Get<R::AccountId>, | ||
| { | ||
| fn on_nonzero_unbalanced(amount: Credit<R::AccountId, pallet_balances::Pallet<R>>) { | ||
| ResolveTo::<BlockAuthorAccountId<R>, pallet_balances::Pallet<R>>::on_unbalanced(amount); | ||
| } | ||
| } |
There was a problem hiding this comment.
We could move this code and DealWithSubstrateFeesAndTip to common and share the implementation with all runtimes
There was a problem hiding this comment.
I kept it separate since the original DealWithFees was repeated in all runtimes with the same code
RomarQ
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Expand on the work done in #2923 and #3043, and send the priority fees to the block author (collator).
What important points reviewers should know?
FeesTreasuryProportionis used to split the followingDealWithFeesstruct and replaced it withDealWithSubstrateFeesAndTipDealWithEthereumBaseFeesDealWithEthereumPriorityFeesTests
Some tests that were checking fees have been updated. Previously, they used the block author (ALITH), who will now receive tips due to this change, causing inaccuracies in the calculations.
Reviewer Checklist:
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?