⚠️ WIP CI: Add weight difference report to PRs #3124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
ci
WASM runtime size check:Compared to target branchMoonbase runtime: 2276 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2244 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2276 KB (+248 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2244 KB (+232 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/weight-diff-report +/- ##
===========================================================
Coverage 74.49% 74.49% 0.00%
Files 375 375
Lines 95313 95313
===========================================================
Hits 70998 70998
Misses 24315 24315
|
RomarQ
reviewed
Jan 6, 2025
| @@ -62,7 +62,7 @@ impl<T: frame_system::Config> cumulus_pallet_parachain_system::WeightInfo for We | |||
| // Measured: `82` | |||
| // Estimated: `3517` | |||
| // Minimum execution time: 2_153_000 picoseconds. | |||
| Weight::from_parts(2_247_000, 3517) | |||
There was a problem hiding this comment.
This change should be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?