CI 📈: Add workflow for checking changes to weights in all runtimes #3129
+114
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2268 KB (no changes) ✅ Moonbeam runtime: 2252 KB (no changes) ✅ Moonriver runtime: 2260 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2268 KB (+240 KB compared to latest release) Moonbeam runtime: 2252 KB (+240 KB compared to latest release) Moonriver runtime: 2260 KB (+248 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/ext-weight-diff-report +/- ##
===============================================================
Coverage 74.40% 74.40% 0.00%
Files 376 376
Lines 95432 95432
===============================================================
Hits 70998 70998
Misses 24434 24434
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds a new CI workflow which checks if files inside the
weightsfolder changed for each runtime and generates a report of the changes sorted by Change %. It will only run for PRs that change the files generated by benchmarks.Reports look like the following:
What important points reviewers should know?
Is there something left for follow-up PRs?
Currently, big changes might generate massive reports. If they end up being unreadable, this workflow could be changed to show only a summary in the PR discussion and upload full reports as artifacts or publish them as HTML pages.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?