Non louping diamonds #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the setup for being able to read facet info even for Diamond contracts that do not mounte DiamondLoupeFacet.
`eth-brownie` strategy of pinning versions of dependencies makes it very hard to add other dependencies. Created an issue for this on the brownie repo: eth-brownie/brownie#1516
This means that Inspector Facet now works with Diamond proxies that don't have a mounted `DiamondLoupeFacet`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Inspector Facet now supports inspection of EIP2535 Diamond proxies which don't implement the
DiamondLoupeFacetinterface.How to test these changes?
Tested live against a contract that does have
DiamondLoupeFacetattached to make sure it works.Related issues
Resolves #2