Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue 360; write return image view in order as expected by FRB #361

Merged
merged 1 commit into from
May 24, 2024
Merged

Fix for issue 360; write return image view in order as expected by FRB #361

merged 1 commit into from
May 24, 2024

Conversation

smithbk
Copy link
Contributor

@smithbk smithbk commented May 23, 2024 •
edited by adamdecaf
Loading

Fixes #360

@smithbk smithbk requested a review from atonks2 as a code owner May 23, 2024 18:55
@smithbk smithbk mentioned this pull request May 23, 2024
Closed
adamdecaf
adamdecaf approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@adamdecaf adamdecaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't break any tests? We have tests for other tag ordering situations, so this case should have a test.

@adamdecaf adamdecaf merged commit 0f60418 into moov-io:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdecaf adamdecaf adamdecaf approved these changes

@atonks2 atonks2 Awaiting requested review from atonks2 atonks2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the order written by writeReturnImageView to be as expected by the FRB
2 participants
@smithbk @adamdecaf