Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rtd config to latest style #1025

Merged
merged 1 commit into from
Nov 15, 2023
Merged

update rtd config to latest style #1025

merged 1 commit into from
Nov 15, 2023

Conversation

kn-ms
Copy link
Contributor

@kn-ms kn-ms commented Nov 15, 2023 •
edited
Loading

Bug / Requirement Description

rtd has new requirement to use build.os to specify build os

Solution description

config has been updated

Checklist:

  • Test
  • Example (both test_plan.py and .rst)
  • Documentation (API)
  • News fragment present for release notes
  • MS info leakage check
  • For new driver: driver index page
  • For new assertion: ui/pdf/std renderers, documentation
  • For new cmdline arg: documentation

@kn-ms kn-ms requested a review from Pyifan as a code owner November 15, 2023 14:35
M6AI
M6AI approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@M6AI M6AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://blog.readthedocs.com/use-build-os-config/ it looks good to me.

@kn-ms kn-ms merged commit cfc6332 into morganstanley:main Nov 15, 2023
7 checks passed
@kn-ms kn-ms deleted the fix/read_the_docs branch November 15, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M6AI M6AI M6AI approved these changes

@Pyifan Pyifan Awaiting requested review from Pyifan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kn-ms @M6AI