Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider tvsubtitles.net cannot download subtitles anymore #1354

Closed
mvanbaak opened this issue Mar 30, 2021 · 3 comments
Closed

Provider tvsubtitles.net cannot download subtitles anymore #1354

mvanbaak opened this issue Mar 30, 2021 · 3 comments
Labels
awaiting feedback bug fixed priority:medium

Comments

@mvanbaak
Copy link
Contributor

Describe the bug

The tvsubtitles.net website changed their download page. It no longer redirects directly to a zipfile.
At the moment they use a page with some javascript to create a downloadlink, and redirect the browser to it.

See https://pastebin.com/WieGWHkE
And a debug log sent by discord user DarkKnight: https://pastebin.com/hGXUd9aF

To Reproduce
Steps to reproduce the behavior:

  1. Enable provider tvsubtitles.net
  2. Search for subtitles on any tv show episode
  3. Click 'download on any subtitle listed on the provider tvsubtitles.net
  4. See error

Expected behavior
The subtitle file is downloaded, unzipped, and saved

Software (please complete the following information):

  • Bazarr: 0.9.4-beta.11 but probably in all bazarr versions. It's a subliminal provider bug
@morpheus65535
Copy link
Owner

This one is quite simple:

var s1= 'fil';
...
var s2= 'es/P';
var s3= 'ea';
var s4= 'ky Blinders_4x01_HDTV.BRISK.en.zip';
document.location = s1+s2+s3+s4;

Download link is a concatenation of s1, s2, s3 and s4.

I'll update the provider.

morpheus65535 added a commit that referenced this issue Mar 31, 2021
@morpheus65535
Fixed tvsubtitles provider #1354
1a025b6
@morpheus65535
Copy link
Owner

Should be fixed in upcoming beta.12

mvanbaak added a commit to mvanbaak/bazarr that referenced this issue Mar 31, 2021
@mvanbaak
Merge remote-tracking branch 'upstream/development' into document-bun…
884cde3 
…dled-dependencies

* upstream/development:
  Release 0.9.4-beta.12
  no log: Changed package_info file location
  no log: Fine-tuning fix for tvsubtitles provider
  Fixed tvsubtitles provider morpheus65535#1354
  no log: Remove Generate Package Info step
  no log: Add a step to generate package info
  Fixed some providers key to match the actual providers name in subliminal_patch morpheus65535#1353
  Updated the init process to get the branch from package_info in docker images
  no log: Add a step to build standalone version in action and upload to asset
@mvanbaak
Copy link
Contributor Author

Confirmed. Working in beta.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting feedback bug fixed priority:medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mvanbaak @morpheus65535 @LASER-Yi