Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations of embedded English hearing-impaired subtitles to Portuguese result in a 500 Error #2689

Closed
YetAnotherTechBro opened this issue Sep 30, 2024 · 7 comments

Comments

@YetAnotherTechBro
Copy link

YetAnotherTechBro commented Sep 30, 2024

Describe the bug

Firstly, thank you for the fantastic work on the subtitle translation refactor. It has become much more reliable and accurate! 🙇

Recently, I’ve encountered an issue when translating embedded English hearing-impaired subtitles into Portuguese. The error message says Error 500 and You have disconnected from the server.

image

This error doesn't happen when translating to other languages like Spanish or when translating non-hearing-impaired English subtitles into Portuguese. Moreover, if I use the Remove HI Tags tool, the translation proceeds without issue.

Despite the error message, I can still use Bazarr normally, which leads me to believe it might be an uncaught exception with a generic error message.

To Reproduce

  1. Enable "Embedded Subtitles" as a provider.
  2. Locate content with embedded English hearing-impaired subtitles and download it.
  3. Attempt to translate the subtitles into Portuguese.
  4. Observe the error.

Expected behavior
The translation from hearing-impaired English to Portuguese occurs without errors.

Software (please complete the following information):

  • Bazarr Version: 1.4.4
  • Package Version: v1.4.4-ls269 by linuxserver.io
  • OS: Linux-6.8.0-76060800daily20240311-generic-x86_64
  • Python Version: 3.12.6

Additional context

Note: I had to append .txt to the subtitle file to upload it on GitHub.

@YetAnotherTechBro
Copy link
Author

YetAnotherTechBro commented Sep 30, 2024

I’ve also noticed that when using the "Mass Edit" feature to translate multiple subtitles at once, the process slows down significantly after a certain point, taking several minutes. The logs show that this is due to hitting the rate limit.

Although the translations eventually complete, the resulting subtitles are either still in the original language or a mix of the original and the target translation language.

I suspect this is a bug, as we have backoff logic in place to handle timeouts properly. Here are the logs showcasing this behavior.

@morpheus65535
Copy link
Owner

Yeah definitely a bug but we're too close to releasing an urgent fix in 1.4.5 so I'll postpone this one for a couple of days. I'm planning to rework the translation tool anyway.

@morpheus65535
Copy link
Owner

The Portuguese translation issue should be fixed in upcoming beta.

@YetAnotherTechBro
Copy link
Author

Thanks for your help!

Just out of curiosity, what is the typical release schedule for Bazarr's stable versions? Do you follow specific criteria when deciding to merge development into the main branch?

@morpheus65535
Copy link
Owner

There's no typical delay. We try do it once every 1 to 2 months unless we have some urgent issue to fix. It's the case in 1.4.4 and we'll release 1.4.5 in the upcoming hours.

@YetAnotherTechBro
Copy link
Author

Got it, thank you!

@YetAnotherTechBro
Copy link
Author

The Portuguese translation issue should be fixed in upcoming beta.

I just tested the fix in v1.4.5, and the EN:HI to PT translation is working now. Thank you! 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants