Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failing on dev #478

Closed
pakim249CAL opened this issue Feb 6, 2023 · 3 comments · Fixed by #469
Closed

CI failing on dev #478

pakim249CAL opened this issue Feb 6, 2023 · 3 comments · Fixed by #469
Assignees
@Rubilmax

Comments

@pakim249CAL
Copy link
Contributor

pakim249CAL commented Feb 6, 2023 •
edited
Loading

IDK why
@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Feb 7, 2023 •
edited
Loading

The path is wrong when running the internal tests
Screenshot 2023-02-07 at 10 54 10

I'm suspecting that the NETWORK is not set.

EDIT: it seems ok though...

@Rubilmax
Copy link
Collaborator

Rubilmax commented Feb 7, 2023

It has something to do with the latest version of foundry, don't update. It's broken again, we just have to wait

@Rubilmax
Copy link
Collaborator

Rubilmax commented Feb 7, 2023 •
edited
Loading

Ok I got it: the error states that the key addressesProvider does not exist in the json config passed as a string

Investigating

EDIT: it's because foundry now requires us to pass absolute path identified by a . prefix

@Rubilmax Rubilmax linked a pull request Feb 7, 2023 that will close this issue
Improve test setup again again #469
Merged
@Rubilmax Rubilmax self-assigned this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve test setup again again morpho-org/morpho-aavev3-optimizer
3 participants
@Rubilmax @MerlinEgalite @pakim249CAL