Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test setup again again #469

Merged
merged 12 commits into from
Feb 8, 2023
Merged

Improve test setup again again #469

merged 12 commits into from
Feb 8, 2023

Conversation

Rubilmax
Copy link
Collaborator

@Rubilmax Rubilmax commented Feb 6, 2023

Pull Request

Issue(s) fixed

This pull request introduce changes to the test setup

@Rubilmax Rubilmax marked this pull request as ready for review February 6, 2023 16:36
MerlinEgalite
MerlinEgalite previously approved these changes Feb 6, 2023
View reviewed changes
test/helpers/TestMarketLib.sol Outdated Show resolved Hide resolved
Tristan22400
Tristan22400 previously requested changes Feb 6, 2023
View reviewed changes
test/helpers/TestMarketLib.sol Outdated Show resolved Hide resolved
test/helpers/TestMarketLib.sol Outdated Show resolved Hide resolved
test/helpers/IntegrationTest.sol Outdated Show resolved Hide resolved
pakim249CAL
pakim249CAL previously approved these changes Feb 7, 2023
View reviewed changes
@Rubilmax Rubilmax dismissed stale reviews from pakim249CAL and MerlinEgalite via 0a18c8e February 7, 2023 09:32
@Rubilmax Rubilmax changed the base branch from dev to chore/remove-mock-folder February 7, 2023 09:32
@Rubilmax Rubilmax linked an issue Feb 7, 2023 that may be closed by this pull request
CI failing on dev #478
Closed
MerlinEgalite
MerlinEgalite previously approved these changes Feb 7, 2023
View reviewed changes
test/helpers/BaseTest.sol Show resolved Hide resolved
test/helpers/TestMarketLib.sol Outdated Show resolved Hide resolved
pakim249CAL
pakim249CAL previously approved these changes Feb 7, 2023
View reviewed changes
Base automatically changed from chore/remove-mock-folder to dev February 7, 2023 13:07
@Rubilmax Rubilmax dismissed stale reviews from pakim249CAL and MerlinEgalite via 0dcdc8e February 7, 2023 14:58
pakim249CAL
pakim249CAL previously approved these changes Feb 7, 2023
View reviewed changes
MerlinEgalite
MerlinEgalite previously approved these changes Feb 7, 2023
View reviewed changes
test/helpers/TestMarketLib.sol Show resolved Hide resolved
Tristan22400
Tristan22400 previously approved these changes Feb 8, 2023
View reviewed changes
test/helpers/TestConfigLib.sol Show resolved Hide resolved
test/helpers/IntegrationTest.sol Show resolved Hide resolved
test/helpers/TestConfigLib.sol Show resolved Hide resolved
test/helpers/IntegrationTest.sol Show resolved Hide resolved
@Rubilmax
Copy link
Collaborator Author

Rubilmax commented Feb 8, 2023 •
edited
Loading

Force-pushed by error, shouldn't have

@Rubilmax Rubilmax closed this Feb 8, 2023
@Rubilmax Rubilmax reopened this Feb 8, 2023
@MerlinEgalite
Copy link
Contributor

nooooo

MerlinEgalite
MerlinEgalite previously approved these changes Feb 8, 2023
View reviewed changes
@Rubilmax Rubilmax merged commit 9330625 into dev Feb 8, 2023
@Rubilmax Rubilmax deleted the test/setup-2 branch February 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Tristan22400 Tristan22400 Tristan22400 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing on dev
4 participants
@Rubilmax @MerlinEgalite @Tristan22400 @pakim249CAL