Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix realize bad debt not reducing borrow #102

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Fix realize bad debt not reducing borrow #102

merged 4 commits into from
Jul 11, 2023

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery self-assigned this Jul 10, 2023
@QGarchery QGarchery changed the base branch from main to dev July 10, 2023 15:21
@QGarchery QGarchery linked an issue Jul 10, 2023 that may be closed by this pull request
Realizing bad debt should not penalize borrowers #101
Closed
Rubilmax
Rubilmax previously approved these changes Jul 10, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Jul 10, 2023
View reviewed changes
MathisGD
MathisGD requested changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the tests

@QGarchery
Copy link
Contributor Author

please update the tests

They seem to pass so I assume that you mean to add a test for it. At the same time, isn't the conclusion of #60 that it's too early to add tests ?

@MathisGD
Copy link
Contributor

We should at least update the existing bad debt realization test

makcandrov
makcandrov previously approved these changes Jul 10, 2023
View reviewed changes
@QGarchery QGarchery dismissed stale reviews from makcandrov, pakim249CAL, and Rubilmax via fd458a7 July 11, 2023 08:55
@QGarchery QGarchery changed the base branch from dev to main July 11, 2023 09:01
@QGarchery QGarchery merged commit 70d50a5 into main Jul 11, 2023
@QGarchery QGarchery deleted the fix/realize-bad-borrow branch July 11, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

@makcandrov makcandrov Awaiting requested review from makcandrov

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Realizing bad debt should not penalize borrowers
7 participants
@QGarchery @MathisGD @Rubilmax @MerlinEgalite @pakim249CAL @Jean-Grimal @makcandrov