Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardhat CI #118

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Hardhat CI #118

merged 3 commits into from
Jul 12, 2023

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Jul 11, 2023 •
edited
Loading

@QGarchery QGarchery self-assigned this Jul 11, 2023
@QGarchery QGarchery linked an issue Jul 11, 2023 that may be closed by this pull request
CI is run 2 times in parallel for no reason #115
Closed
@QGarchery QGarchery mentioned this pull request Jul 11, 2023
Merged
@QGarchery QGarchery linked an issue Jul 11, 2023 that may be closed by this pull request
Add hardhat tests to the CI #117
Closed
@QGarchery QGarchery marked this pull request as ready for review July 11, 2023 16:52
@QGarchery QGarchery merged commit c68c25f into main Jul 12, 2023
@QGarchery QGarchery deleted the ci/hardhat branch July 12, 2023 08:10
MathisGD
MathisGD reviewed Jul 12, 2023
View reviewed changes
.github/workflows/foundry.yml
Comment on lines 4 to 7
push:
branches:
- main
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not all push and not pull_request ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this setting for performance reasons, so I kept it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD left review comments

@makcandrov makcandrov makcandrov approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hardhat tests to the CI CI is run 2 times in parallel for no reason
6 participants
@QGarchery @Rubilmax @MerlinEgalite @pakim249CAL @MathisGD @makcandrov