fix(repay/withdraw): edge case #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
commented
Jul 19, 2023
| @@ -121,18 +121,22 @@ contract Blue { | |||
| function withdraw(Market calldata market, uint256 amount, address onBehalf) external { | |||
| Id id = market.id(); | |||
| require(lastUpdate[id] != 0, "unknown market"); | |||
| if (amount == type(uint256).max) { | |||
| amount = supplyShare[id][msg.sender].toAssetsDown(totalSupply[id], totalSupplyShares[id]); | |||
There was a problem hiding this comment.
This calculation was performed before accruing interests.
| require(isSenderOrIsApproved(onBehalf), "not approved"); | ||
|
|
||
| accrueInterests(market, id); | ||
|
|
||
| uint256 shares = amount.toSharesUp(totalSupply[id], totalSupplyShares[id]); |
There was a problem hiding this comment.
shares <= supplyShare[id][onBehalf] was not guaranteed because of #123 (comment).
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
Jean-Grimal
reviewed
Jul 19, 2023
Co-authored-by: Jean-Grimal <[email protected]> Signed-off-by: Romain Milon <[email protected]>
Rubilmax
commented
Jul 19, 2023
Signed-off-by: Romain Milon <[email protected]>
MerlinEgalite
approved these changes
Jul 19, 2023
Jean-Grimal
approved these changes
Jul 19, 2023
pakim249CAL
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were actually 2 issues with the feature. See PR comments.