refactor(callbacks): split callbacks #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I prefer #166 over this |
|
It seems more people are in favor of this implementation... @pakim249CAL @QGarchery what are your thoughts? |
makcandrov
requested review from
Rubilmax,
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD and
Jean-Grimal
makcandrov
changed the title
Rubilmax
approved these changes
Jul 26, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: makcandrov <[email protected]>
Jean-Grimal
approved these changes
Jul 26, 2023
pakim249CAL
reviewed
Jul 26, 2023
|
Let's merge this one ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121 --> #166 vs #167
I guess we should conduct a poll... react with a thumbs up/down to this comment to indicate whether you are okay/not okay with this implementation