refactor(wad): remove wad constant declaration #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
pakim249CAL
previously approved these changes
Jul 25, 2023
Jean-Grimal
previously approved these changes
Jul 25, 2023
makcandrov
previously approved these changes
Jul 26, 2023
MerlinEgalite
previously approved these changes
Jul 27, 2023
MathisGD
reviewed
Jul 27, 2023
I tried and unfortunately I could not find a way to do it... 😭 |
|
It would work if WAD was outside of the lib in FixedPointMathLib.sol but it's not the case. I'm still not 100% convinced that we should not do our own math lib custom for Blue. |
Signed-off-by: MathisGD <[email protected]>
MathisGD
dismissed stale reviews from MerlinEgalite, makcandrov, Jean-Grimal, and pakim249CAL
via
d82badf
MathisGD
reviewed
Jul 27, 2023
Signed-off-by: MathisGD <[email protected]>
MathisGD
approved these changes
Jul 27, 2023
MathisGD
requested review from
MerlinEgalite,
pakim249CAL,
Jean-Grimal and
makcandrov
pakim249CAL
approved these changes
Jul 27, 2023
MerlinEgalite
approved these changes
Jul 28, 2023
makcandrov
approved these changes
Jul 28, 2023
Jean-Grimal
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.