Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(hardhat): skip mining sometimes #198

Merged
merged 4 commits into from
Jul 31, 2023
Merged

test(hardhat): skip mining sometimes #198

merged 4 commits into from
Jul 31, 2023

Conversation

Rubilmax
Copy link
Collaborator

No description provided.

@Rubilmax Rubilmax force-pushed the test/skip-mining-sometimes branch from 4b484c7 to 9aa9e8f Compare July 31, 2023 08:47
@Rubilmax Rubilmax marked this pull request as ready for review July 31, 2023 08:47
@Rubilmax Rubilmax requested a review from makcandrov July 31, 2023 08:47
@Rubilmax Rubilmax mentioned this pull request Jul 31, 2023
Merged
makcandrov
makcandrov previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@makcandrov makcandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

MathisGD
MathisGD previously approved these changes Jul 31, 2023
View reviewed changes
hardhat.config.ts Show resolved Hide resolved
@MathisGD
Copy link
Contributor

hardhat tests seem infinite again 👀

@Rubilmax
Copy link
Collaborator Author

hardhat tests seem infinite again 👀

I pushed a fix but GitHub's ignoring the commit...

MerlinEgalite
MerlinEgalite previously approved these changes Jul 31, 2023
View reviewed changes
@Rubilmax Rubilmax force-pushed the test/skip-mining-sometimes branch from 364a5e7 to 6970ae3 Compare July 31, 2023 13:33
Base automatically changed from refactor/skip-interest-accrual to main July 31, 2023 16:03
@MathisGD MathisGD dismissed stale reviews from MerlinEgalite, makcandrov, and themself July 31, 2023 16:03

The base branch was changed.

@MathisGD MathisGD merged commit 60278e4 into main Jul 31, 2023
@MathisGD MathisGD deleted the test/skip-mining-sometimes branch July 31, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees

@Rubilmax Rubilmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rubilmax @MathisGD @MerlinEgalite @pakim249CAL @Jean-Grimal @makcandrov