refactor(blue): use single oracle #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Rubilmax
commented
Jul 31, 2023
Rubilmax
commented
- Fixes Use only one oracle #197
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
Jean-Grimal
reviewed
Jul 31, 2023
MerlinEgalite
previously approved these changes
Aug 1, 2023
makcandrov
reviewed
Aug 1, 2023
Jean-Grimal
previously approved these changes
Aug 1, 2023
MathisGD
reviewed
Aug 1, 2023
Rubilmax
dismissed stale reviews from Jean-Grimal and MerlinEgalite
via
16110ff
Rubilmax
requested review from
MathisGD,
makcandrov,
MerlinEgalite and
Jean-Grimal
makcandrov
previously approved these changes
Aug 1, 2023
pakim249CAL
previously approved these changes
Aug 1, 2023
Jean-Grimal
previously approved these changes
Aug 2, 2023
MerlinEgalite
previously approved these changes
Aug 3, 2023
|
@Rubilmax to update |
Rubilmax
dismissed stale reviews from MerlinEgalite, Jean-Grimal, and pakim249CAL
via
1a3bb68
QGarchery
previously approved these changes
Aug 8, 2023
julien-devatom
previously approved these changes
Aug 8, 2023
|
I think that we should not expect the scale as an output of the oracle and rather should choose a coherent fixed scale. Yes, there can always be a well chosen asset pair that are unusable given a fixed scale. But it's still not worth the added complexity in Blue and oracles to me. To verify but 10e36 feels largely enough (the decimal difference is below 18 99% of the time, and if the price ratio is above 10e-14 you still have 0.01% precision). Edit:
actually it does not really complexifies the code, but more the framework and the work required to do an oracle |
MathisGD
requested changes
Aug 9, 2023
|
Let's postpone this choice |
MathisGD
previously approved these changes
Aug 9, 2023
Signed-off-by: Romain Milon <[email protected]>
Rubilmax
dismissed stale reviews from MathisGD, julien-devatom, QGarchery, pakim249CAL, Jean-Grimal, MerlinEgalite, and makcandrov
via
5bbbe77
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
julien-devatom,
pakim249CAL,
MathisGD,
Jean-Grimal and
makcandrov
makcandrov
approved these changes
Aug 9, 2023
pakim249CAL
approved these changes
Aug 9, 2023
MathisGD
approved these changes
Aug 9, 2023
QGarchery
approved these changes
Aug 9, 2023
Jean-Grimal
approved these changes
Aug 9, 2023
MerlinEgalite
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.