Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move events #220

Merged
merged 2 commits into from
Aug 7, 2023
Merged

refactor: move events #220

merged 2 commits into from
Aug 7, 2023

Conversation

pakim249CAL
Copy link
Contributor

Fixes #219

@pakim249CAL pakim249CAL marked this pull request as ready for review August 3, 2023 17:16
MathisGD
MathisGD previously approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it

makcandrov
makcandrov previously approved these changes Aug 3, 2023
View reviewed changes
MerlinEgalite
MerlinEgalite previously approved these changes Aug 3, 2023
View reviewed changes
Jean-Grimal
Jean-Grimal previously approved these changes Aug 4, 2023
View reviewed changes
Rubilmax

This comment was marked as outdated.

Sign in to view

@MerlinEgalite MerlinEgalite merged commit 021b39b into main Aug 7, 2023
@MerlinEgalite MerlinEgalite deleted the refactor/event-to-interface branch August 7, 2023 07:47
QGarchery pushed a commit that referenced this pull request Aug 7, 2023
@MerlinEgalite @QGarchery
Merge pull request #220 from morpho-labs/refactor/event-to-interface
9ca6524 
refactor: make setAuthorization idempotent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider moving events to interface
6 participants
@pakim249CAL @Rubilmax @MerlinEgalite @MathisGD @Jean-Grimal @makcandrov