refactor: setAuthorization => setAuthorizationWithSig

[julien-devatom]

Pull request

Remove duplicated function name with different signatures to clarify the interface.

It is harder to type functions in any other language if the function name is the same but the behavior nor parameters are not.

The workaround (used on Morpho Optimizers) is to rename offchain the function, or define a function name more explicit (setAuthorization(address,address,bool) instead of setAutorization for example) when we are interfacing blue, which is less readable.

So to clarify everything, I suggest to have a more explicit function name

[QGarchery]

I don't have a strong opinion on this (I approved), but do you have specific reasons for this change ? In solidity, optional arguments are usually implemented using the same function name, and it kind of fits the bill here

[MathisGD]

I don't have a strong opinion on this (I approved), but do you have specific reasons for this change ? In solidity, optional arguments are usually implemented using the same function name, and it kind of fits the bill here

It is not really optional arguments neither here. It is more a fundamentally different logic.

[QGarchery]

It is not really optional arguments neither here. It is more a fundamentally different logic.

Yes it's not the same thing, but from a very high level you give the authorization either by being the sender or by providing the additional "optional" arguments authorizer, deadline and signature (the distinction is only syntactic anyway). But I'm fine with either

[MathisGD]

Julien also added the technical reasons why he opened the PR