Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move events back to lib #263

Merged
merged 2 commits into from
Aug 10, 2023
Merged

refactor: move events back to lib #263

merged 2 commits into from
Aug 10, 2023

Conversation

pakim249CAL
Copy link
Contributor

Fixes #262

@pakim249CAL pakim249CAL marked this pull request as ready for review August 10, 2023 14:12
MathisGD
MathisGD requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except this I'm approving

src/libraries/Events.sol Outdated Show resolved Hide resolved
@pakim249CAL pakim249CAL requested a review from MathisGD August 10, 2023 14:19
@MathisGD MathisGD merged commit 553c16a into main Aug 10, 2023
@MathisGD MathisGD deleted the refactor/events branch August 10, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makcandrov makcandrov makcandrov approved these changes

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events in interfaces seem to produce compiler errors when testing
5 participants
@pakim249CAL @Rubilmax @MerlinEgalite @MathisGD @makcandrov