Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom libs #280

Merged
merged 19 commits into from
Aug 13, 2023
Merged

Custom libs #280

merged 19 commits into from
Aug 13, 2023

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite commented Aug 12, 2023

To do:

  • Finish math lib -> revert on denominator == 0
  • Test math lib (or use OZ one?)
  • Test Transfer lib

@MerlinEgalite MerlinEgalite requested review from a team, Rubilmax, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and MathisGD and removed request for a team August 13, 2023 09:44
@MerlinEgalite MerlinEgalite marked this pull request as ready for review August 13, 2023 09:44
@pakim249CAL pakim249CAL mentioned this pull request Aug 13, 2023
4 tasks
@pakim249CAL
Copy link
Contributor

I'm sure it's a tired stance at this point, but I think that it's almost always better to import and use battle tested code like OZ rather than try to build and use our own if they accommodate our use cases.

Only saying this because the description of this PR is asking.

src/libraries/SafeTransferLib.sol Outdated Show resolved Hide resolved
src/libraries/SafeTransferLib.sol Outdated Show resolved Hide resolved
src/libraries/SafeTransferLib.sol Outdated Show resolved Hide resolved
src/libraries/SafeTransferLib.sol Outdated Show resolved Hide resolved
src/interfaces/IERC20.sol Outdated Show resolved Hide resolved
src/libraries/MathLib.sol Show resolved Hide resolved
src/libraries/MathLib.sol Show resolved Hide resolved
@MerlinEgalite
Copy link
Contributor Author

I'm sure it's a tired stance at this point, but I think that it's almost always better to import and use battle tested code like OZ rather than try to build and use our own if they accommodate our use cases.

Only saying this because the description of this PR is asking.

The issue with OZ is that much of the logic is useless for us and add a lots of complexity

pakim249CAL
pakim249CAL previously approved these changes Aug 13, 2023
src/interfaces/IERC20.sol Outdated Show resolved Hide resolved
pakim249CAL
pakim249CAL previously approved these changes Aug 13, 2023
@MathisGD MathisGD linked an issue Aug 13, 2023 that may be closed by this pull request
test/forge/SafeTransferLib.t.sol Outdated Show resolved Hide resolved
test/forge/SafeTransferLib.t.sol Outdated Show resolved Hide resolved
test/forge/SafeTransferLib.t.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite merged commit c66e53d into main Aug 13, 2023
@MerlinEgalite MerlinEgalite deleted the feat/custom-libs branch August 13, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Third-party libraries are copy/pasted
4 participants