Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setAuthorizationWithSig and add warning message #284

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Refactor setAuthorizationWithSig and add warning message #284

merged 2 commits into from
Aug 13, 2023

Conversation

MathisGD
Copy link
Contributor

@MathisGD MathisGD requested review from a team August 13, 2023 10:12
@MathisGD MathisGD self-assigned this Aug 13, 2023
@MathisGD MathisGD requested review from Rubilmax, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and julien-devatom and removed request for a team August 13, 2023 10:12
MerlinEgalite
MerlinEgalite previously approved these changes Aug 13, 2023
View reviewed changes
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
src/interfaces/IMorpho.sol Outdated Show resolved Hide resolved
@MathisGD @MerlinEgalite
docs: improve authorization doc
9030a71 
Co-authored-by: Merlin Egalite <[email protected]>
Signed-off-by: MathisGD <[email protected]>
@MathisGD MathisGD requested a review from MerlinEgalite August 13, 2023 16:14
julien-devatom
julien-devatom approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@julien-devatom julien-devatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the logic and the idea, but I've not checked in depth if there is any issue

@MathisGD MathisGD merged commit 5c5ecaa into main Aug 13, 2023
@MathisGD MathisGD deleted the refactor/set-auth-with-sig branch August 13, 2023 17:44
@MathisGD MathisGD mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakim249CAL pakim249CAL pakim249CAL approved these changes

@julien-devatom julien-devatom julien-devatom approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@Rubilmax Rubilmax Awaiting requested review from Rubilmax Rubilmax was automatically assigned from morpho-labs/onchain

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal Jean-Grimal was automatically assigned from morpho-labs/onchain

@makcandrov makcandrov Awaiting requested review from makcandrov makcandrov was automatically assigned from morpho-labs/onchain

@QGarchery QGarchery Awaiting requested review from QGarchery QGarchery was automatically assigned from morpho-labs/protocol

@peyha peyha Awaiting requested review from peyha peyha was automatically assigned from morpho-labs/protocol

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MathisGD @MerlinEgalite @julien-devatom @pakim249CAL