[Certora] Cannot lose position & can withdraw all #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jhoenicke
commented
Aug 17, 2023
jhoenicke
commented
- user cannot lose supply shares or gain borrow shares by someone else (not authorized)
- a user without borrow shares cannot lose collateral
- a healthy user cannot lose collateral if no time passes and price doesn't change.
- authorization can only be changed by user or setAuthorizationWithSig
- lastUpdate is always smaller equal to block number.
- it's possible to withdraw all shares if nobody else borrows.
QGarchery
approved these changes
Aug 18, 2023
| function getVirtualTotalSupply(MorphoHarness.Id) external returns uint256 envfree; | ||
| function getVirtualTotalSupplyShares(MorphoHarness.Id) external returns uint256 envfree; | ||
| function supplyShares(MorphoHarness.Id, address user) external returns uint256 envfree; |
There was a problem hiding this comment.
This line is duplicated at line 7
QGarchery
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.