Various small improvements #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MathisGD
commented
Aug 19, 2023
•
MathisGD
commented
- add a zero check in constructor because if you deploy with owner = 0 you can't list IRMs and LLTVs
- add a dev doc
- remove wMulUp because it is not used
- Fix Document owner's role #366
- Fix a local variable shadowing in IMorpho (but one is still remaining in user arg)
MathisGD
requested review from
a team,
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery and
peyha
and removed request for
a team
QGarchery
previously approved these changes
Aug 19, 2023
MerlinEgalite
requested changes
Aug 19, 2023
MerlinEgalite
requested changes
Aug 19, 2023
Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
previously approved these changes
Aug 19, 2023
Signed-off-by: Merlin Egalite <[email protected]>
MerlinEgalite
approved these changes
Aug 19, 2023
julien-devatom
approved these changes
Aug 19, 2023
pakim249CAL
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.