-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add license #420
feat: add license #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update all files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many files with the UNLICENSED
keyword still. Those are test files and in the src/mocks
folder too. Should they be GPL2 or MIT ?
I intentionally left them as |
Yes I think it should be changed, it feels like it is an oversight otherwise and it's better if the rules are clear |
I think that legally something unlicensed is equivalents to the most permissive ones, so why not just put that ? Edit: no it is not, so we want something more permissive, just in case someone needs them for production use in some ways |
40eb4e2
285f88e
to
48ff2ea
Compare
Signed-off-by: Merlin Egalite <[email protected]>
License Workshop