Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(position): rename user to position #423

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Conversation

Rubilmax
Copy link
Collaborator

Naming suggestion

@Rubilmax Rubilmax requested review from a team, MerlinEgalite, pakim249CAL, Jean-Grimal, makcandrov, QGarchery, peyha and MathisGD and removed request for a team August 23, 2023 12:52
@Rubilmax Rubilmax marked this pull request as ready for review August 23, 2023 12:52
@QGarchery
Copy link
Contributor

This is much better indeed

MathisGD
MathisGD previously approved these changes Aug 23, 2023
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

src/interfaces/IMorpho.sol Show resolved Hide resolved
src/Morpho.sol Show resolved Hide resolved
MathisGD
MathisGD previously approved these changes Aug 23, 2023
QGarchery
QGarchery previously approved these changes Aug 23, 2023
src/interfaces/IMorpho.sol Show resolved Hide resolved
@Rubilmax Rubilmax dismissed stale reviews from QGarchery and MathisGD via d44b4eb August 23, 2023 14:11
@Rubilmax Rubilmax requested review from QGarchery and MathisGD August 23, 2023 14:11
MathisGD
MathisGD previously approved these changes Aug 23, 2023
src/Morpho.sol Outdated Show resolved Hide resolved
src/Morpho.sol Outdated Show resolved Hide resolved
pakim249CAL
pakim249CAL previously approved these changes Aug 23, 2023
@MerlinEgalite MerlinEgalite merged commit 57b3c56 into main Aug 24, 2023
@MerlinEgalite MerlinEgalite deleted the refactor/position branch August 24, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants