-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(position): rename user to position #423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
a team,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
QGarchery,
peyha and
MathisGD
and removed request for
a team
August 23, 2023 12:52
This is much better indeed |
MathisGD
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great !
Rubilmax
force-pushed
the
refactor/position
branch
from
August 23, 2023 13:05
342be48
to
3019d91
Compare
MathisGD
previously approved these changes
Aug 23, 2023
QGarchery
previously approved these changes
Aug 23, 2023
MathisGD
previously approved these changes
Aug 23, 2023
MerlinEgalite
requested changes
Aug 23, 2023
pakim249CAL
previously approved these changes
Aug 23, 2023
MathisGD
approved these changes
Aug 24, 2023
makcandrov
approved these changes
Aug 24, 2023
QGarchery
approved these changes
Aug 24, 2023
MerlinEgalite
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming suggestion