Tests minor fixes #431
Merged
Tests minor fixes #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
Rubilmax,
MerlinEgalite,
pakim249CAL,
Jean-Grimal,
makcandrov,
peyha and
MathisGD
and removed request for
a team
But then it becomes misleading with Morpho Blue functions as well no? |
Yes you are right, even though they are essentially calling Morpho Blue functions. The suffix |
MathisGD
approved these changes
Aug 24, 2023
Rubilmax
approved these changes
Aug 24, 2023
pakim249CAL
approved these changes
Aug 24, 2023
MerlinEgalite
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
OnMorphosuffix on tests because it is not needed and it can be misleading with how the callbacks are named