Simplify isHealthy
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
Rubilmax,
MerlinEgalite,
pakim249CAL and
MathisGD
makcandrov
previously approved these changes
Jul 5, 2023
Rubilmax
previously approved these changes
Jul 5, 2023
|
Related to #24 |
MerlinEgalite
previously approved these changes
Jul 5, 2023
MerlinEgalite
dismissed stale reviews from Rubilmax, makcandrov, and themself
The base branch was changed.
Rubilmax
approved these changes
Jul 5, 2023
pakim249CAL
approved these changes
Jul 5, 2023
MerlinEgalite
approved these changes
Jul 5, 2023
MathisGD
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
I'm generally against strongly against early "returns" (it should not even be called return this thing but that is an other discussion).
Here the function is very simple though, and it makes sense to wanting to optimize this case as much as possible since it happens every time that a user would be withdrawing their collateral after having repay their debt.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor of
isHealthythat I find more readable