Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ifc): add edge case #632

Merged
merged 4 commits into from
Dec 8, 2023
Merged

docs(ifc): add edge case #632

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a822196
docs(ifc): add edge case
Rubilmax Dec 5, 2023
4d18f59
docs(ifc): fix supply -> borrow
Rubilmax Dec 5, 2023
9772375
docs(ifc): remove comment
Rubilmax Dec 5, 2023
511fdfb
Merge branch 'docs/imorpho' of github.com:morpho-labs/blue into docs/…
Rubilmax Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/libraries/periphery/MorphoBalancesLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ library MorphoBalancesLib {

/// @notice Returns the expected supply assets balance of `user` on a market after having accrued interest.
/// @dev Warning: Wrong for `feeRecipient` because their supply shares increase is not taken into account.
/// @dev Warning: Withdrawing a supply position using the expected assets balance can lead to a revert due to
/// conversion roundings between shares and assets.
/// @dev Warning: Withdrawing using the expected supply assets can lead to a revert due to conversion roundings from
/// assets to shares.
function expectedSupplyAssets(IMorpho morpho, MarketParams memory marketParams, address user)
internal
view
Expand All @@ -105,8 +105,8 @@ library MorphoBalancesLib {
}

/// @notice Returns the expected borrow assets balance of `user` on a market after having accrued interest.
/// @dev Warning: repaying a borrow position using the expected assets balance can lead to a revert due to
/// conversion roundings between shares and assets.
/// @dev Warning: The expected balance is rounded up, so it may be greater than the market's expected total borrow
/// assets.
function expectedBorrowAssets(IMorpho morpho, MarketParams memory marketParams, address user)
internal
view
Expand Down
Loading