post-cantina #633
Merged
post-cantina #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs(ifc): fix comments
Co-authored-by: Quentin Garchery <[email protected]> Signed-off-by: Romain Milon <[email protected]>
fix(safe-transfer-lib): check for code
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Update `post-cantina`
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Co-authored-by: MathisGD <[email protected]> Signed-off-by: Merlin Egalite <[email protected]>
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
refactor(liquidate): rename intermediary var
test(irm): dont fuzz irm
…uidate Rounding liquidate fix
fix(authorization): revert already set error
MerlinEgalite
requested review from
a team,
adhusson,
Rubilmax,
MerlinEgalite,
MathisGD and
Jean-Grimal
and removed request for
a team
MerlinEgalite
approved these changes
Dec 20, 2023
Rubilmax
approved these changes
Dec 20, 2023
MathisGD
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
SafeTransferLib.safeTransfer&SafeTransferLib.safeTransferFrom(#5)SupplyCollateral,Borrow,WithdrawCollateralevent (#24, #23, #25)feeinMorpho.setFee(#48)repay&liquidate(#90)abi.encodePackedinstead ofbytes.concat(#325)setAuthorization(#431). Part of this change is later reverted in fix(authorization): revert already set error #652.liquidate,flashLoan&accrueInterest(#503)flashLoan(#670)borrowRate(#686)feeRecipient(#699)MorphoBalancesLib.expectedSupplyAssets&MorphoBalancesLib.expectedBorrowAssets(MorphoBalancesLib.expectedBorrowAssetsmay return a value greater thantotalBorrowAssets#628)badDebtAssetsinLiquidateeventliquidate(#461). Must be combined with Rounding liquidate fix #653address(0)(IRM zero #631)liquidatesetAuthorizationWithSigshould not revert with "already set"