Vinyl's file method pipe is being removed
#66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks for your input. The second commit here belongs to another issue, which I'm not ready to merge now. Would you mind reverting the "Propagate error" commit here? If not I'll cherry pick locally. |
|
@morris sure! Sorry about that. |
|
Refiled here in a proper topic branch: #70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I stumbled on the fact that vinyl removed the
pipemethod 4 days ago.gulpjs/vinyl#107
This the change required to cope with that removal.
Note: if the gulp maintainers are reading this issue I dont think it is a bad thing: I was mocking a vinyl File and found out I needed to implement the pipe method for my mock to work with vinyl-ftp. Once this change is released I wont need to code the
pipemethod anymore.Cheers!