Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved special chars handling #8

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

syrnyk
Copy link

@syrnyk syrnyk commented Dec 31, 2024

No description provided.

src/utils.ts Show resolved Hide resolved
src/hooks/HltbApi.ts Outdated Show resolved Hide resolved
@syrnyk syrnyk changed the title fix: improved special chars handling and API name retrieval fix: improved special chars handling Jan 1, 2025
@morwy
Copy link
Owner

morwy commented Jan 2, 2025

Regex changes look good to me.

@syrnyk
Copy link
Author

syrnyk commented Jan 3, 2025

Regex changes look good to me.

Great, thanks. Feel free to merge the changes on your repo and package it in a future version, we don't need another repo providing a different version of the plugin. I've created a develop branch on my fork where I merged my changes from the 2 PRs, I've used this version for the past few days with no issues so far.

@morwy morwy marked this pull request as ready for review January 4, 2025 19:21
@morwy morwy merged commit 15e0dde into morwy:main Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants