Clean up OOM Observer Remote Uploader Download Path (#3070)

mosaicml · May 16, 2024 · 41e745a · 41e745a
1 parent 2e1db9f
commit 41e745a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/composer/callbacks/oom_observer.py b/composer/callbacks/oom_observer.py
@@ -157,7 +157,9 @@ def oom_observer(device: int, alloc: int, device_alloc: int, device_free: int):
                             snapshot_file, trace_plot_file, segment_plot_file, segment_flamegraph_file,
                             memory_flamegraph_file
                     ]:
-                        remote_file_name = (self.remote_path_in_bucket + os.path.basename(f)).lstrip('/')
+                        base_file_name = os.path.basename(f)
+                        remote_file_name = os.path.join(self.remote_path_in_bucket, base_file_name)
+                        remote_file_name = remote_file_name.lstrip('/')  # remove leading slashes
                         log.info(f'Uploading memory visualization to remote: {remote_file_name} from {f}')
                         try:
                             logger.upload_file(remote_file_name=remote_file_name, file_path=f, overwrite=self.overwrite)