Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to dashes in image names #2858

Closed
wants to merge 2 commits into from
Closed

Change to dashes in image names #2858

wants to merge 2 commits into from

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Changes docker names to use - everywhere so it is consistent as other projects (eg nvidia) do

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner January 13, 2024 23:27
@mvpatel2000 mvpatel2000 requested review from b-chu and dakinggg January 17, 2024 19:08
b-chu
b-chu reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a search for _cpu, etc in the repo to make sure you caught all the necessary changes

docker/README.md Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 requested a review from b-chu January 17, 2024 21:42
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-name branch January 18, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg Awaiting requested review from dakinggg

@b-chu b-chu Awaiting requested review from b-chu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @b-chu