-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version upgrade vincent #2892
Version upgrade vincent #2892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KuuCi what do you think about updating dockerfiles later once torch 2.2 comes out and tie 3.11 to that for images?
Let's just replace torch 2.1.2 with 3.11 and keep rest at existing? WDYT. Also ok with bumping all if ur confident
@mvpatel2000 Some reason not letting me reply so I'll edit here. TLDR is I want to make sure what I have now with python 3.11 and torch 2.1.2 is working fine -- once that passes I will do one more sweep and add torch 2.2 integration. Should be able to get done within next 2-3 days, though hard to tell because the image creation run time is for some reason kind of finicky rn.
| Ubuntu 20.04 | Base | 2.1.2 | 12.1.0 (Infiniband) | 3.10 | `mosaicml/pytorch:latest`, `mosaicml/pytorch:2.1.2_cu121-python3.10-ubuntu20.04` | | ||
| Ubuntu 20.04 | Base | 2.1.2 | 12.1.0 (EFA) | 3.10 | `mosaicml/pytorch:latest-aws`, `mosaicml/pytorch:2.1.2_cu121-python3.10-ubuntu20.04-aws` | | ||
| Ubuntu 20.04 | Base | 2.1.2 | cpu | 3.10 | `mosaicml/pytorch:latest_cpu`, `mosaicml/pytorch:2.1.2_cpu-python3.10-ubuntu20.04` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no red here for stability reasons. How about we only add a nightly python3.11 entry and only have one green.
if python_version == '3.11': | ||
return ['2.1.2'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's just make this a nightly entry
urllib3${URLLIB3_VERSION} \ | ||
python-snappy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the FA2 changes?
Upgrading python 3.10 to 3.11