Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup of UC get_object_size #2989

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Minor cleanup of UC get_object_size #2989

merged 3 commits into from
Feb 9, 2024

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Feb 9, 2024

Also adds a unit test

Manual test still good

In [4]: uc.get_object_size('train.jsonl')
Out[4]: 1000000

@dakinggg dakinggg marked this pull request as ready for review February 9, 2024 06:42
panchalhp-db
panchalhp-db approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@panchalhp-db panchalhp-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

@dakinggg dakinggg enabled auto-merge (squash) February 9, 2024 06:50
nancyhung
nancyhung approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@nancyhung nancyhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakinggg dakinggg merged commit 1a22691 into mosaicml:dev Feb 9, 2024
14 checks passed
@dakinggg dakinggg deleted the uc-cleanup branch February 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panchalhp-db panchalhp-db panchalhp-db approved these changes

@nancyhung nancyhung nancyhung approved these changes

@irenedea irenedea Awaiting requested review from irenedea

@jbloxham jbloxham Awaiting requested review from jbloxham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @nancyhung @panchalhp-db