Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate get_state and remove deprecations #3017

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Deprecate get_state and remove deprecations #3017

merged 3 commits into from
Feb 27, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Feb 15, 2024 •
edited
Loading

What does this PR do?

commit-id:5d87db4b

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

This was referenced Feb 15, 2024
Closed
Closed
@b-chu b-chu force-pushed the spr/dev/5d87db4b branch 5 times, most recently from f3e78ea to 4d1c487 Compare February 15, 2024 21:25
@b-chu b-chu marked this pull request as ready for review February 15, 2024 21:37
@b-chu b-chu requested a review from a team as a code owner February 15, 2024 21:37
snarayan21
snarayan21 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :0000

@b-chu b-chu mentioned this pull request Feb 15, 2024
Closed
7 tasks
b-chu added 2 commits February 16, 2024 23:07
@b-chu
Add duration to to_next_epoch
feaeffd 
Adds duration to the to_next_epoch function to increment total_wct.

commit-id:5f8ef9be
@b-chu
Add iteration to TimeUnit
7b0a44b 
commit-id:e4729f79
@b-chu b-chu changed the base branch from spr/dev/e4729f79 to dev February 27, 2024 18:08
@b-chu b-chu merged commit 4e178f9 into dev Feb 27, 2024
12 checks passed
@b-chu b-chu deleted the spr/dev/5d87db4b branch February 27, 2024 18:08
@b-chu b-chu mentioned this pull request Mar 5, 2024
Merged
7 tasks
j316chuck pushed a commit that referenced this pull request Mar 29, 2024
@b-chu @j316chuck
Deprecate get_state and remove deprecations (#3017)
e5390b7 
* Add duration to to_next_epoch

Adds duration to the to_next_epoch function to increment total_wct.

commit-id:5f8ef9be

* Add iteration to TimeUnit

commit-id:e4729f79

* Deprecate get_state and remove deprecations

commit-id:5d87db4b
j316chuck pushed a commit that referenced this pull request May 16, 2024
@b-chu
Deprecate get_state and remove deprecations (#3017)
a456fa0 
* Add duration to to_next_epoch

Adds duration to the to_next_epoch function to increment total_wct.

commit-id:5f8ef9be

* Add iteration to TimeUnit

commit-id:e4729f79

* Deprecate get_state and remove deprecations

commit-id:5d87db4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@j316chuck j316chuck j316chuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@b-chu @j316chuck @mvpatel2000 @snarayan21