Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close the engine if its already closed #3143

Merged
merged 2 commits into from
May 2, 2024
Merged

Don't close the engine if its already closed #3143

merged 2 commits into from
May 2, 2024

Conversation

dakinggg
Copy link
Contributor

What does this PR do?

Currently produces duplicate print statements cause it may close both when you call .close() and atexit

@dakinggg dakinggg requested a review from mvpatel2000 March 24, 2024 23:00
@dakinggg dakinggg marked this pull request as ready for review March 24, 2024 23:00
mvpatel2000
mvpatel2000 approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this possible...?

@dakinggg dakinggg merged commit 3736dcf into mosaicml:dev May 2, 2024
15 checks passed
j316chuck pushed a commit that referenced this pull request May 16, 2024
@dakinggg
Don't close the engine if its already closed (#3143)
5380eb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000